Skip to content

Add all editor task types to project #1658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 6, 2024
Merged

Add all editor task types to project #1658

merged 1 commit into from
Jun 6, 2024

Conversation

vbrodsky
Copy link
Contributor

@vbrodsky vbrodsky commented Jun 6, 2024

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Document change (fix typo or modifying any markdown files, code comments or anything in the examples folder only)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

New Feature Submissions

  • Does your submission pass tests?
  • Have you added thorough tests for your new feature?
  • Have you commented your code, particularly in hard-to-understand areas?
  • Have you added a Docstring?

Changes to Core Features

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you updated any code comments, as applicable?

@vbrodsky vbrodsky requested a review from a team as a code owner June 6, 2024 20:45
adrian-chang
adrian-chang previously approved these changes Jun 6, 2024
View reviewed changes
Tim-Kerr
Tim-Kerr reviewed Jun 6, 2024
View reviewed changes
libs/labelbox/src/labelbox/schema/ontology_kind.py Outdated
@@ -25,6 +25,8 @@ def get_ontology_kind_validation_error(cls, ontology_kind):

class EditorTaskType(Enum):
ModelChatEvaluation = "MODEL_CHAT_EVALUATION"
ResponseCreation = "RESPONSE_CREATION"
ModelEvaluationWithUploadedAsset = "MODEL_EVALUATION_WITH_UPLOADED_ASSET"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The _uploaded_asset type isn’t used anywhere. Should be safe to omit

@vbrodsky vbrodsky force-pushed the VB/get-project-support-LLM branch from a2925ec to 3e5936b Compare June 6, 2024 21:31
@vbrodsky vbrodsky merged commit 0d97cd9 into develop Jun 6, 2024
18 of 22 checks passed
@vbrodsky vbrodsky deleted the VB/get-project-support-LLM branch June 6, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tim-Kerr Tim-Kerr Tim-Kerr approved these changes

@sfendell-labelbox sfendell-labelbox sfendell-labelbox approved these changes

@adrian-chang adrian-chang adrian-chang left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vbrodsky @adrian-chang @Tim-Kerr @sfendell-labelbox